alamb commented on code in PR #10405: URL: https://github.com/apache/datafusion/pull/10405#discussion_r1592520545
########## datafusion/sqllogictest/test_files/cte.slt: ########## @@ -31,10 +31,9 @@ query TT EXPLAIN WITH "NUMBERS" AS (SELECT 1 as a, 2 as b, 3 as c) SELECT "NUMBERS".* FROM "NUMBERS" ---- logical_plan -01)Projection: NUMBERS.a, NUMBERS.b, NUMBERS.c -02)--SubqueryAlias: NUMBERS -03)----Projection: Int64(1) AS a, Int64(2) AS b, Int64(3) AS c -04)------EmptyRelation +01)SubqueryAlias: NUMBERS Review Comment: I believe these plans are better -- they have one less unecessary `Projection` (I believe the changes are due to better tracking of child rewrites during optimization) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
