viirya commented on code in PR #355:
URL: https://github.com/apache/datafusion-comet/pull/355#discussion_r1585190305
##########
spark/src/test/scala/org/apache/comet/exec/CometJoinSuite.scala:
##########
@@ -40,6 +40,24 @@ class CometJoinSuite extends CometTestBase {
}
}
+ test("SortMergeJoin with unsupported key type should fall back to Spark") {
+ withSQLConf(
+ SQLConf.SESSION_LOCAL_TIMEZONE.key -> "Asia/Kathmandu",
+ SQLConf.ADAPTIVE_AUTO_BROADCASTJOIN_THRESHOLD.key -> "-1",
+ SQLConf.AUTO_BROADCASTJOIN_THRESHOLD.key -> "-1") {
+ withTable("t1", "t2") {
+ sql("CREATE TABLE t1(name STRING, time TIMESTAMP) USING PARQUET")
+ sql("INSERT OVERWRITE t1 VALUES('a', timestamp'2019-01-01 11:11:11')")
+
+ sql("CREATE TABLE t2(name STRING, time TIMESTAMP) USING PARQUET")
+ sql("INSERT OVERWRITE t2 VALUES('a', timestamp'2019-01-01 11:11:11')")
+
+ val df = sql("SELECT * FROM t1 JOIN t2 ON t1.time = t2.time")
+ checkSparkAnswer(df)
Review Comment:
Before the fix, the query will simply fail with exception. But it would be
better to check if it falls back. Let me update it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
