Omega359 commented on code in PR #10302:
URL: https://github.com/apache/datafusion/pull/10302#discussion_r1583963327
##########
datafusion/optimizer/src/eliminate_filter.rs:
##########
@@ -78,17 +56,47 @@ impl OptimizerRule for EliminateFilter {
fn apply_order(&self) -> Option<ApplyOrder> {
Some(ApplyOrder::TopDown)
}
+
+ fn supports_rewrite(&self) -> bool {
+ true
+ }
+
+ fn rewrite(
+ &self,
+ plan: LogicalPlan,
+ _config: &dyn OptimizerConfig,
Review Comment:
I believe the code in this function uses this so it likely should not start
with an underscore as that is a convention to indicate it's not used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
