parthchandra commented on code in PR #307:
URL: https://github.com/apache/datafusion-comet/pull/307#discussion_r1576817617
##########
spark/src/test/scala/org/apache/comet/CometCastSuite.scala:
##########
@@ -66,19 +66,22 @@ class CometCastSuite extends CometTestBase with
AdaptiveSparkPlanHelper {
castTest(testValues, DataTypes.BooleanType)
}
- ignore("cast string to byte") {
- castTest(generateStrings(numericPattern, 8).toDF("a"), DataTypes.ByteType)
+ test("cast string to byte") {
+ val testValues =
+ Seq("", ".", "0", "-0", "+1", "-1", ".2", "-.2", "1e1", "127", "128",
"-128", "-129") ++
+ generateStrings(numericPattern, 8)
+ castTest(testValues.toDF("a"), DataTypes.ByteType)
}
- ignore("cast string to short") {
+ test("cast string to short") {
Review Comment:
We should probably have some negative tests with invalid strings.
Also, curious, what does `cast(".")` yield?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
