Abacn commented on code in PR #36781: URL: https://github.com/apache/beam/pull/36781#discussion_r2984322491
########## sdks/java/core/src/main/java/org/apache/beam/sdk/metrics/MetricsLineage.java: ########## @@ -0,0 +1,60 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.beam.sdk.metrics; + +import org.apache.beam.sdk.lineage.LineageBase; +import org.apache.beam.sdk.metrics.Metrics.MetricsFlag; +import org.apache.beam.vendor.guava.v32_1_2_jre.com.google.common.collect.ImmutableList; + +/** + * Default lineage implementation that stores lineage information in Beam metrics. + * + * <p>This implementation uses either {@link BoundedTrie} or {@link StringSet} metrics depending on + * the {@link MetricsFlag#lineageRollupEnabled()} flag. + */ +public class MetricsLineage implements LineageBase { + + private final Metric metric; + + public MetricsLineage(final Lineage.LineageDirection direction) { + // Derive Metrics-specific Type from LineageDirection + Lineage.Type type = + (direction == Lineage.LineageDirection.SOURCE) ? Lineage.Type.SOURCE : Lineage.Type.SINK; + + if (MetricsFlag.lineageRollupEnabled()) { + this.metric = + Metrics.boundedTrie( + Lineage.LINEAGE_NAMESPACE, + direction == Lineage.LineageDirection.SOURCE + ? Lineage.Type.SOURCEV2.toString() + : Lineage.Type.SINKV2.toString()); + } else { + this.metric = Metrics.stringSet(Lineage.LINEAGE_NAMESPACE, type.toString()); + } + } + + @Override + public void add(final Iterable<String> rollupSegments) { + ImmutableList<String> segments = ImmutableList.copyOf(rollupSegments); + if (MetricsFlag.lineageRollupEnabled()) { + ((BoundedTrie) this.metric).add(segments); Review Comment: There was an assumption (and coupling) between lineageRollupEnabled<->BoundedTrie. With common interface we can now avoid unchecked cast by implementing CounterMetricsLineage and TrieMetricsLineage separately. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
