bvolpato commented on code in PR #37178:
URL: https://github.com/apache/beam/pull/37178#discussion_r2972687730
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsub/PubsubUnboundedSink.java:
##########
@@ -248,6 +248,7 @@ private static class OutgoingData {
private final @Nullable ValueProvider<TopicPath> topic;
private final String timestampAttribute;
private final String idAttribute;
+ private final int publishBatchSize;
Review Comment:
What happens when publishBatchSize is not explicitly set? Does it default to
1000 (the Pub/Sub limit)? If so, this is safe. If it defaults to 0 or some
other value, there could be a regression. It would be helpful to add a test
that verifies the default behavior without explicitly setting the batch size.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
