Abacn commented on code in PR #37739:
URL: https://github.com/apache/beam/pull/37739#discussion_r2966965484
##########
website/www/site/layouts/partials/section-menu/en/documentation.html:
##########
@@ -69,15 +69,16 @@
<li class="section-nav-item--collapsible">
<span class="section-nav-list-title">I/O connector guides</span>
<ul class="section-nav-list">
- <li><a href="/documentation/io/built-in/parquet/">Apache Parquet
I/O connector</a></li>
- <li><a href="/documentation/io/built-in/hadoop/">Hadoop
Input/Output Format IO</a></li>
+ <li><a href="/documentation/io/built-in/iceberg/">Apache
Iceberg</a></li>
Review Comment:
How are them ordered? Should we use alphabetical order or TOP IOs first +
alphabetical order in remaining
##########
website/www/site/content/en/documentation/io/built-in/iceberg.md:
##########
@@ -0,0 +1,433 @@
+---
+title: "Apache Iceberg"
Review Comment:
Consider a different title? This affectd Tab ttile on browser.
<img width="235" height="38" alt="Image"
src="https://github.com/user-attachments/assets/27b201b1-5473-4a52-99a7-068f14b11d2f";
/>
##########
examples/java/build.gradle:
##########
@@ -56,6 +56,7 @@ dependencies {
implementation project(":sdks:java:io:google-cloud-platform")
implementation project(":sdks:java:io:kafka")
implementation project(":sdks:java:extensions:ml")
+ implementation project(":sdks:java:managed")
Review Comment:
We should keep iceberg examples in examples/java/iceberg. There is an
incoming risk Iceberg needs to be handled separately again as newer versions do
not support Java11
##########
sdks/java/io/iceberg/src/main/java/org/apache/beam/sdk/io/iceberg/IcebergScanConfig.java:
##########
@@ -65,9 +67,13 @@ public enum ScanType {
@Pure
public abstract String getTableIdentifier();
+ private static final Logger LOG =
LoggerFactory.getLogger(IcebergScanConfig.class);
+
@Pure
public Table getTable() {
if (cachedTable == null) {
+ System.out.println("xxx loading a new table");
Review Comment:
debug leftovers
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
