acrites commented on code in PR #37691:
URL: https://github.com/apache/beam/pull/37691#discussion_r2881209806
##########
sdks/java/harness/src/main/java/org/apache/beam/fn/harness/control/ProcessBundleHandler.java:
##########
@@ -246,7 +246,9 @@ private void addRunnerAndConsumersForPTransformRecursively(
BundleFinalizer bundleFinalizer,
Collection<BeamFnDataReadRunner<?>> channelRoots,
Map<ApiServiceDescriptor, BeamFnDataOutboundAggregator>
outboundAggregatorMap,
- Set<String> runnerCapabilities)
+ Set<String> runnerCapabilities,
+ boolean hasNoState,
Review Comment:
Something to think about: do we need to worry about the case where
`onlyBundleForKeys` is true and `hasNoState` is false? I think that should
never happen. If that's true, then we should have a check somewhere in this
whole stack (ideally as early as possible).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
