tvalentyn commented on code in PR #37725:
URL: https://github.com/apache/beam/pull/37725#discussion_r2875107303
##########
sdks/python/tox.ini:
##########
@@ -561,7 +562,7 @@ commands =
/bin/sh -c "pip freeze | grep -E google-cloud-aiplatform"
/bin/sh -c "pip freeze | grep -E transformers"
# Allow exit code 5 (no tests run) so that we can run this command safely on
arbitrary subdirectories.
- /bin/sh -c 'pytest apache_beam/ml/transforms/embeddings -o
junit_suite_name={envname} --junitxml=pytest_{envname}.xml -n 6 {posargs};
ret=$?; [ $ret = 5 ] && exit 0 || exit $ret'
+ /bin/sh -c 'pytest apache_beam/ml/transforms/embeddings -o
junit_suite_name={envname} --junitxml=pytest_{envname}.xml -n 6 -m "not
vertex_ai_postcommit" {posargs}; ret=$?; [ $ret = 5 ] && exit 0 || exit $ret'
Review Comment:
i don't like that we might have to remember to exclude some tests here; can
we think of an approach where tests are not run (for example, test is skipped
because it detects that a dep is not installed, or test is placed in a folder
that is not picked up by this suite), rather than having to exclude certain
tests?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
