derrickaw commented on PR #37594: URL: https://github.com/apache/beam/pull/37594#issuecomment-3976227856
> > The PR was not tested due to the constant failure of: > > I can rollback if you want. Thanks. > > Yaml precomit is now green and no need to revert. However it seems the newly added test isn't get exercised. > > PreCommit YAML Xlang Direct: > > ``` > apache_beam/yaml/integration_tests.py::FilterTest::test_WriteToJson_ExternalJavaProvider_1 PASSED [ 2%] > apache_beam/yaml/integration_tests.py::FilterTest::test_WriteToJson_InlineProvider_0 PASSED [ 4%] > apache_beam/yaml/integration_tests.py::TextTest::test_only PASSED [ 6%] > apache_beam/yaml/integration_tests.py::ParquetTest::test_only PASSED [ 8%] > apache_beam/yaml/integration_tests.py::ExplodeTest::test_Explode_ExternalJavaProvider_1 PASSED [ 10%] > apache_beam/yaml/integration_tests.py::ExplodeTest::test_Explode_InlineProvider_0 PASSED [ 13%] > apache_beam/yaml/integration_tests.py::Validate_With_SchemaTest::test_only PASSED [ 15%] > apache_beam/yaml/integration_tests.py::PytransformTest::test_WriteToCsv_ExternalJavaProvider_1 PASSED [ 17%] > apache_beam/yaml/integration_tests.py::PytransformTest::test_WriteToCsv_InlineProvider_0 PASSED [ 19%] > apache_beam/yaml/integration_tests.py::JavaMapTest::test_Explode_ExternalJavaProvider_1 PASSED [ 21%] > apache_beam/yaml/integration_tests.py::JavaMapTest::test_Explode_InlineProvider_0 PASSED [ 23%] > apache_beam/yaml/integration_tests.py::MapTest::test_Filter-generic_ExternalJavaProvider_MapToFields-generic_ExternalJavaProvider_3 PASSED [ 26%] > apache_beam/yaml/integration_tests.py::MapTest::test_Filter-generic_ExternalJavaProvider_MapToFields-generic_InlineProvider_2 PASSED [ 28%] > apache_beam/yaml/integration_tests.py::MapTest::test_Filter-generic_InlineProvider_MapToFields-generic_ExternalJavaProvider_1 PASSED [ 30%] > apache_beam/yaml/integration_tests.py::MapTest::test_Filter-generic_InlineProvider_MapToFields-generic_InlineProvider_0 PASSED [ 32%] > apache_beam/yaml/integration_tests.py::TsvTest::test_WriteToCsv_ExternalJavaProvider_1 PASSED [ 34%] > apache_beam/yaml/integration_tests.py::TsvTest::test_WriteToCsv_InlineProvider_0 PASSED [ 36%] > apache_beam/yaml/integration_tests.py::Assign_TimestampsTest::test_only PASSED [ 39%] > apache_beam/yaml/integration_tests.py::Ml_TransformTest::test_only PASSED [ 41%] > apache_beam/yaml/integration_tests.py::BigtableTest::test_only PASSED [ 43%] > apache_beam/yaml/integration_tests.py::PartitionTest::test_WriteToJson_ExternalJavaProvider_1 PASSED [ 45%] > apache_beam/yaml/integration_tests.py::PartitionTest::test_WriteToJson_InlineProvider_0 PASSED [ 47%] > apache_beam/yaml/integration_tests.py::Extract_Windowing_InfoTest::test_only PASSED [ 50%] > apache_beam/yaml/integration_tests.py::SqlTest::test_only PASSED [ 52%] > apache_beam/yaml/integration_tests.py::JoinTest::test_only PASSED [ 54%] > apache_beam/yaml/integration_tests.py::CsvTest::test_WriteToCsv_ExternalJavaProvider_1 PASSED [ 56%] > apache_beam/yaml/integration_tests.py::CsvTest::test_WriteToCsv_InlineProvider_0 PASSED [ 58%] > apache_beam/yaml/integration_tests.py::WindowintoTest::test_Combine-generic_ExternalJavaProvider_WindowInto_ExternalJavaProvider_3 PASSED [ 60%] > apache_beam/yaml/integration_tests.py::WindowintoTest::test_Combine-generic_ExternalJavaProvider_WindowInto_InlineProvider_2 PASSED [ 63%] > apache_beam/yaml/integration_tests.py::WindowintoTest::test_Combine-generic_InlineProvider_WindowInto_ExternalJavaProvider_1 PASSED [ 65%] > apache_beam/yaml/integration_tests.py::WindowintoTest::test_Combine-generic_InlineProvider_WindowInto_InlineProvider_0 PASSED [ 67%] > apache_beam/yaml/integration_tests.py::WindowingTest::test_Combine-generic_ExternalJavaProvider_WindowInto_ExternalJavaProvider_3 PASSED [ 69%] > apache_beam/yaml/integration_tests.py::WindowingTest::test_Combine-generic_ExternalJavaProvider_WindowInto_InlineProvider_2 PASSED [ 71%] > apache_beam/yaml/integration_tests.py::WindowingTest::test_Combine-generic_InlineProvider_WindowInto_ExternalJavaProvider_1 PASSED [ 73%] > apache_beam/yaml/integration_tests.py::WindowingTest::test_Combine-generic_InlineProvider_WindowInto_InlineProvider_0 PASSED [ 76%] > apache_beam/yaml/integration_tests.py::JsonTest::test_WriteToJson_ExternalJavaProvider_1 PASSED [ 78%] > apache_beam/yaml/integration_tests.py::JsonTest::test_WriteToJson_InlineProvider_0 PASSED [ 80%] > apache_beam/yaml/integration_tests.py::FlattenTest::test_Flatten_ExternalJavaProvider_1 PASSED [ 82%] > apache_beam/yaml/integration_tests.py::FlattenTest::test_Flatten_ExternalJavaProvider_2 PASSED [ 84%] > apache_beam/yaml/integration_tests.py::FlattenTest::test_Flatten_ExternalJavaProvider_3 PASSED [ 86%] > apache_beam/yaml/integration_tests.py::FlattenTest::test_Flatten_ExternalJavaProvider_4 PASSED [ 89%] > apache_beam/yaml/integration_tests.py::FlattenTest::test_Flatten_InlineProvider_0 PASSED [ 91%] > apache_beam/yaml/integration_tests.py::IcebergTest::test_only PASSED [ 93%] > apache_beam/yaml/integration_tests.py::CreateTest::test_only PASSED [ 95%] > apache_beam/yaml/integration_tests.py::AvroTest::test_only PASSED [ 97%] > apache_beam/yaml/integration_tests.py::RuninferenceTest::test_only PASSED [100%] > ``` > > beam_PostCommit_Yaml_Xlang_Direct: > > ``` > apache_beam/yaml/integration_tests.py::PubsubTest::test_only PASSED [ 50%] > apache_beam/yaml/integration_tests.py::KafkaTest::test_only PASSED [100%] > apache_beam/yaml/integration_tests.py::SpannerTest::test_only PASSED [ 12%] > apache_beam/yaml/integration_tests.py::OracleTest::test_only PASSED [ 25%] > apache_beam/yaml/integration_tests.py::BigqueryTest::test_ReadFromBigQuery_InlineProvider_1 PASSED [ 37%] > apache_beam/yaml/integration_tests.py::MysqlTest::test_only PASSED [ 50%] > apache_beam/yaml/integration_tests.py::SqlserverTest::test_only PASSED [ 62%] > apache_beam/yaml/integration_tests.py::PostgresTest::test_only PASSED [ 75%] > apache_beam/yaml/integration_tests.py::JdbcTest::test_only PASSED [ 87%] > apache_beam/yaml/integration_tests.py::IcebergTest::test_only PASSED [100%] > apache_beam/yaml/integration_tests.py::TfrecordTest::test_ReadFromTFRecord_ExternalJavaProvider_WriteToTFRecord_ExternalJavaProvider_3 PASSED [ 20%] > apache_beam/yaml/integration_tests.py::TfrecordTest::test_ReadFromTFRecord_ExternalJavaProvider_WriteToTFRecord_InlineProvider_2 PASSED [ 40%] > apache_beam/yaml/integration_tests.py::TfrecordTest::test_ReadFromTFRecord_InlineProvider_WriteToTFRecord_ExternalJavaProvider_1 PASSED [ 60%] > apache_beam/yaml/integration_tests.py::TfrecordTest::test_ReadFromTFRecord_InlineProvider_WriteToTFRecord_InlineProvider_0 PASSED [ 80%] > apache_beam/yaml/integration_tests.py::EnrichmentTest::test_only PASSED [100%] > ``` > > Did I miss something? I forgot this isn't covered by pre or post commit tests. These are just manually verified or mocked tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
