damccorm commented on PR #37709: URL: https://github.com/apache/beam/pull/37709#issuecomment-3960086866
Just adding some context - we noticed that the PR being reverted causes some existing use cases to fail. Specifically, if you have a proto which does not set all required fields, `value.ByteSize()` will fail while the other encoding/decoding is able to succeed. While maybe unusual, I think it is valid to construct a proto throughout your beam pipeline and have only some fields filled in between steps, so I think we should support encoding/decoding protos like this where possible. @robertwb any thoughts? One option is to just merge https://github.com/apache/beam/pull/37710 in the release branch to give us more time to figure this out -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
