junaiddshaukat opened a new pull request, #37553:
URL: https://github.com/apache/beam/pull/37553
## Summary
PR #34659 introduced a "fail fast" feature using `checkState()` in
`GenerateKafkaSourceDescriptor` and `WatchForKafkaTopicPartitions`. However,
when Kafka returns `null` or an empty partition list for a topic,
`checkState()` throws `IllegalStateException` inside DoFns. Since DoFns
automatically retry on exceptions, this causes **infinite retries** instead of
cleanly stopping the pipeline — the opposite of the intended "fail fast"
behavior.
## Fix
Replaced `checkState()` assertions with `LOG.warn()` + `continue` in both
classes. When a topic has no available partitions:
- A warning is logged so operators can investigate the Kafka configuration
- The topic is skipped gracefully, allowing the pipeline to continue
processing other valid topics
- No exception is thrown, preventing the infinite retry loop
## What I changed
| File | Change |
|------|--------|
| `KafkaIO.java` | Replaced `checkState` / `if-else` branching with
null/empty check, `LOG.warn`, and `continue` in
`GenerateKafkaSourceDescriptor.processElement()` |
| `WatchForKafkaTopicPartitions.java` | Replaced `checkState` with
`LOG.warn` and `continue` in `getAllTopicPartitions()`. Added SLF4J `Logger`. |
| `WatchForKafkaTopicPartitionsTest.java` | Added 3 unit tests: null
partition info, empty partition info, and partial topic availability (one
missing, one valid) |
## Testing
- All existing `WatchForKafkaTopicPartitionsTest` tests pass
- 3 new tests verify the graceful handling:
- `testGetAllTopicPartitionsWithNullPartitionInfo` — returns empty list,
no exception
- `testGetAllTopicPartitionsWithEmptyPartitionInfo` — returns empty list,
no exception
- `testGetAllTopicPartitionsSkipsMissingTopics` — skips missing topic,
returns valid topic's partitions
- `spotlessApply` passes (code formatting verified)
Fixes #37449
------------------------
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [X] Mention the appropriate issue in your description (for example:
`addresses #123`), if applicable. This will automatically add a link to the
pull request in the issue. If you would like the issue to automatically close
on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more
tips on [how to make review process
smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier).
To check the build health, please visit
[https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more
information about GitHub Actions CI or the [workflows
README](https://github.com/apache/beam/blob/master/.github/workflows/README.md)
to see a list of phrases to trigger workflows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
