tvalentyn commented on code in PR #37474:
URL: https://github.com/apache/beam/pull/37474#discussion_r2765720107
##########
sdks/python/apache_beam/pipeline.py:
##########
@@ -226,8 +226,7 @@ def __init__(
raise ValueError(
'Pipeline has validations errors: \n' + '\n'.join(errors))
- typecoders.registry.update_compatibility_version = self._options.view_as(
- StreamingOptions).update_compatibility_version
+ pipeline_construction_options.options = self._options
Review Comment:
I think you meant
pipeline_construction_options.PipelineConstructionOptions.options?
Other thoughts:
- How ceratain are we that this won't cause some race condition? We could
possibly key the singleton by a thread ID.
- I'd prefer we separate the helper portion of the code from refactoring, at
minimum into different commits.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
