damccorm commented on code in PR #37490:
URL: https://github.com/apache/beam/pull/37490#discussion_r2760536907
##########
sdks/python/apache_beam/runners/portability/sdk_container_builder.py:
##########
@@ -262,10 +262,11 @@ def _invoke_docker_build_and_push(self,
container_image_name):
build.steps.append(step)
source = cloud_build_types.Source()
- source.storageSource = cloud_build_types.StorageSource()
+ storage_source = cloud_build_types.StorageSource()
gcs_bucket, gcs_object = self._get_gcs_bucket_and_name(gcs_location)
- source.storageSource.bucket = os.path.join(gcs_bucket)
- source.storageSource.object = gcs_object
+ storage_source.bucket = os.path.join(gcs_bucket)
+ storage_source.object_ = gcs_object
+ source.storage_source = storage_source
Review Comment:
Oh I see - I didn't notice the case shift. Got it, that works, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
