@eht16 commented on this pull request.


> @@ -593,8 +593,8 @@ static void print_external(GeanyDocument *doc)
                return;
        }
 
-       cmdline = g_strdup(printing_prefs.external_print_cmd);
-       utils_str_replace_all(&cmdline, "%f", doc->file_name);
+       /* replace d, e, f and p placeholders in cmdline, ignore return code */

```suggestion
        /* replace d, e, f and p placeholders in cmdline */
```

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/4250#pullrequestreview-2762742854
You are receiving this because you are subscribed to this thread.

Message ID: <geany/geany/pull/4250/review/2762742...@github.com>

Reply via email to