Hiding menubar seems to be one of the more requested features (#633, https://github.com/geany/geany-plugins/issues/1380) and there are various PRs (#2972, https://github.com/geany/geany-plugins/pull/1138, plus I believe some geany-lua script) trying to implement it.
I think the feature makes sense (other editors offer features like "distraction-free" mode where all other widgets are hidden except the editing area), the only dangerous thing is that people might hide the menubar and won't be able to recover it back because they forgot the keybinding. I based the patch on @xiota's implementation from #2972 (thanks!) with some modifications/additions: 1. I removed the configurability part of the patch - i.e. whether hiding the menubar is remembered on Geany restart or not. I understand this is a precaution against having the menubar "lost forever", on the other hand I don't like having a config option for every single small feature - these then start adding up and the result is that everyone gets lost in what's configurable and what not. 2. Instead, I added one more way to "recover" the menu bar - using the context menu. This may be the only UI element left if users hide all other widgets. The "Show menubar" item only appears when the menubar is hidden; when shown, it's removed from the context menu so it doesn't occupy context menu space for people not using this feature. You can view, comment on, or merge this pull request online at: https://github.com/geany/geany/pull/4279 -- Commit Summary -- * Add keybinding and option to change menubar visibility * Remove configurability of menubar startup visibility * Move toggle menubar implementation to a separate function * Add context menu item to reshow menubar -- File Changes -- M doc/geany.txt (6) M src/keybindings.c (54) M src/keybindings.h (2) M src/keyfile.c (7) M src/ui_utils.h (1) -- Patch Links -- https://github.com/geany/geany/pull/4279.patch https://github.com/geany/geany/pull/4279.diff -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/4279 You are receiving this because you are subscribed to this thread. Message ID: <geany/geany/pull/4...@github.com>
