> "sensible value is present" 

Means the `comment_single=..` setting has a value, not when it has an empty 
setting `comment_single=` which unsets values set in overridden system defaults.

It is important to note that you are using the `Toggle Line Commentation` which 
is different to the `Comment Line(s)` and `Uncomment Line(s)` since toggle adds 
the `Comment Toggle Marker` (default preference `~`) to the comment so toggled 
lines are identifiable for untoggle actions.   The comment and uncomment 
actions purely use the comment.

Thats why its important to clearly define what command you are using and the 
actual command by name, which tells readers what it does more clearly than a 
keybinding (eg "Toggle Line Commentation" has meaning vs Ctrl+E which has no 
meaning), and since the keybinding may be modified or defined by a user it is 
better not to use it.

There are only actions for Toggle comment, Comment line, and Uncomment line 
functions which have subtleties in actions depending on which comment settings 
are present and which need someone to check the code what, why, where, etc.

It may be more obvious to have separate commands specifying use of single line 
or multiple token comment actions and the subtleties of behaviour can be 
removed.  PRs may be welcome.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/discussions/3997#discussioncomment-11011403
You are receiving this because you are subscribed to this thread.

Message ID: <geany/geany/repo-discussions/3997/comments/[email protected]>

Reply via email to