> In the end thats all I am suggesting adding now.

Done (plus a couple of weird loop I just couldn't let be).  Let me know how I 
should update all strings :wink: 

> Which one? I only found "encoding of new files" and "use fixed encoding" both 
> of which seem useful?

*Use fixed encoding when opening non-Unicode files*.  It's useful, but we have 
code for adding a *Detect from file* entry directly in the combo box, as used 
in the file Open dialog.  Using this there as well instead of having a separate 
checkbox strikes me as an improvement: simpler UI with less widgets and less 
code.

> Well, ATM its just tests and fixes AFAICT, not sure what you see as 
> "cosmetic"?

Cosmetic is the other this I have for the UI, and I count the more proper error 
message as cosmetic compared to the other fixes.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3716#issuecomment-1852942612
You are receiving this because you are subscribed to this thread.

Message ID: <geany/geany/pull/3716/[email protected]>

Reply via email to