@b4n requested changes on this pull request.
New image is missing from the build system. Otherwise I didn't check all PR
and issue references, but looks good! :+1:
On doc/images/edit_change_history.png:
This is not installed!
```diff
diff --git a/doc/Makefile.am b/doc/Makefile.am
index ea0e0f697..45dbeecef 100644
--- a/doc/Makefile.am
+++ b/doc/Makefile.am
@@ -4,6 +4,7 @@ if INSTALL_HTML_DOCS
htmldocimagesdir = $(docdir)/html/images
dist_htmldocimages_DATA = \
images/build_menu_commands_dialog.png \
+ images/edit_change_history.png \
images/find_dialog.png \
images/find_in_files_dialog.png \
images/main_window.png \
diff --git a/doc/meson.build b/doc/meson.build
index a9a2c0257..2fa8cab6d 100644
--- a/doc/meson.build
+++ b/doc/meson.build
@@ -19,6 +19,7 @@ tarball = run_command('test', '-f', 'geany.html', check:
false)
if tarball.returncode() == 0 or rst2html.found()
install_data(
'images/build_menu_commands_dialog.png',
+ 'images/edit_change_history.png',
'images/find_dialog.png',
'images/find_in_files_dialog.png',
'images/main_window.png',
```
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3593#pullrequestreview-1686319476
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany/pull/3593/review/[email protected]>
