@techee commented on this pull request.
> }
- else if (0 == strcmp(key, "file")) /* static (local)
tag */
- tag->local = TRUE;
- else if (0 == strcmp(key, "signature")) /* arglist */
+ else
+ g_array_append_val(unknown_fields, i);
+ }
+
+ if (!tag->scope)
+ {
+ /* search for scope introduced by scope kind name only
after going
+ * through all extension fields and having tag->lang
updated when
+ * "language" field is present */
+ for (idx = 0; !tag->scope && idx < unknown_fields->len;
idx++)
> Or make this i, and make the local idx, which might be more idiomatic.
Yes, this is better, done this way.
By the way, how did you do these fancy committable "suggested change" thingies
at github?
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3049#discussion_r1360465788
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany/pull/3049/review/[email protected]>
