After updating to Scintilla 5.3.7 the Scintilla popup with the diff against git shows the wrong number.
It seems that gtk_widget_set_size_request() scrolls Scintilla view so despite it was set previously, it isn't set correctly after this call and has to be re-set. Note that the call to SCI_SETFIRSTVISIBLELINE has to stay at the original location too, otherwise subsequent calculation using SCI_POINTXFROMPOSITION doesn't work because the line may not be visible. @b4n Does this look OK to you? Maybe there's a better way to fix this problem so take this only as a hint where the problem is. Fixes #1279 You can view, comment on, or merge this pull request online at: https://github.com/geany/geany-plugins/pull/1280 -- Commit Summary -- * git-changebar: Re-set first visible line after Scintilla size request -- File Changes -- M git-changebar/src/gcb-plugin.c (4) -- Patch Links -- https://github.com/geany/geany-plugins/pull/1280.patch https://github.com/geany/geany-plugins/pull/1280.diff -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1280 You are receiving this because you are subscribed to this thread. Message ID: <geany/geany-plugins/pull/[email protected]>
