Maybe a question - by just having a look at the parser (and not knowing the language), it seems that the parser supports scopes (i.e. nesting one tag inside other tag). The provided unit test only shows some simple script without this. But if scopes are supported, then it should be mentioned inside `tm_parser_has_full_scope()`. Also would be nice to have a unit test that covers scope generation.
I played with the provided unit test a bit and it seems that you can nest one function inside another - in this case the Symbols tree in Geany shows these tags separated by dot instead of displayed as a tree. Adding `TM_PARSER_AUTOIT` to `tm_parser_has_full_scope()` to indicate it has full scope info should fix that. Second, very minor thing is that in https://github.com/geany/geany/pull/3428 we changed comments for `wordchars` and `comment_use_indent` in the filetype config files and they should be changed here too (but it's something we can do once this PR is merged). Apart from these minor and trivial to fix problems everything seems to be present, syntax gets highlighted, tags are generated so I think it can be merged. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1752#issuecomment-1483932720 You are receiving this because you are subscribed to this thread. Message ID: <geany/geany/pull/1752/[email protected]>
