@elextr requested changes on this pull request. AFAICT this requires files in the templates directory to have a filetype extension, this is not backward compatible and undocumented as currently files with any name are added to the menu, whereas now Geany would crash (see comment).
There are a lot of file formats that are not supported by a Geany filetype, this change would now preclude the user from having templates for them. Instead, if a file does not have a filetype extension it should be added to the menu top level like those with a count of 1. > - add_file_item(fname, menu); + if (ft) + group = &ft_groups[ft->id]; + if (group->count == 1) `group` may be NULL if a file in the directory does not have a filetype extension -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3397#pullrequestreview-1296695331 You are receiving this because you are subscribed to this thread. Message ID: <geany/geany/pull/3397/review/[email protected]>
