@eht16 commented on this pull request.


>      else
         new_dir_path = g_build_filename(directory_ref, new_dir, NULL);
 
     /* Build the new file list for completion */
     completion_list = build_file_list(new_dir_path, new_dir);
        gtk_entry_completion_set_model (completion, completion_list);
     g_object_unref(completion_list);
+
+    g_free(new_dir_path);

`curr_dir` is declared static and freed before it is assigned with a new value 
at line 182. But of course, since it is static within the function, the last 
instance will never be freed.
Since I don't know the code and don't want to risk to break more than it helps, 
it would keep it as is.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1197#discussion_r1027319330
You are receiving this because you are subscribed to this thread.

Message ID: <geany/geany-plugins/pull/1197/review/[email protected]>

Reply via email to