> All look very good. Most of those are things I should have considered myself, 
> sorry for that.

Great, good to hear!

> Regarding empty directories, yes, this makes the tree a bit more crowded. It 
> would be possible to haved them hidden and show them only when their parent 
> is selected, maybe with a dimmed icon, but I thought it may be a little bit 
> confusing and, more important, it was too complex for the time I had 
> available.

Yeah, I think it's not worth it. I was thinking about some config option to 
disable showing empty directories (which would kind of kill the "create 
directory" feature for users who would enable it) but I think I'll wait with 
this and see if users are complaining about it or just don't care.

I've created #783 with the extra patches and will close this pull request. 
Thanks a lot for contributing the code!

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/767#issuecomment-430250332

Reply via email to