Well I personally am not really in favour of making file browser into a second rate file manager (as I have ranted in other places :), IMHO thats not its purpose, the Geany Plugins Tree Browser aspires to that.
But at least this is not an actual file manipulation operation, so its possibly ok. If its a simple straightforward PR then it should be ok IMHO. Some questions remain, what are you going to make the default terminal command? The Geany default of xterm does not have a working directory option AFAIK. And on windows? Don't forget to handle commands that don't work properly, since the user can edit them. You will need to substitute the directory path into the command, the traditional placeholder is %d. Be aware that doing things to the built-in terminal is unfortunately messy, see how build.c runs commands there and how that can fail. Because its a core plugin distributed with Geany, filebrowser will in general be held to a higher standard for reliability and user friendliness than treebrowser, so you may need to improve any code you copy. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/1525#issuecomment-312398583
