deniskuzZ commented on code in PR #6270:
URL: https://github.com/apache/hive/pull/6270#discussion_r2795197377


##########
standalone-metastore/metastore-rest-catalog/src/main/java/org/apache/iceberg/rest/HMSCatalogFactory.java:
##########
@@ -81,6 +86,8 @@ private Catalog createCatalog() {
     final String configExtWarehouse = MetastoreConf.getVar(configuration, 
MetastoreConf.ConfVars.WAREHOUSE_EXTERNAL);
     if (configExtWarehouse != null) {
       properties.put("external-warehouse", configExtWarehouse);
+      // HiveCatalog reads this property directly from Configuration, not from 
properties map

Review Comment:
   why not use HIVE_METASTORE_WAREHOUSE_EXTERNAL



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to