deniskuzZ commented on code in PR #6292:
URL: https://github.com/apache/hive/pull/6292#discussion_r2783560373
##########
iceberg/iceberg-catalog/src/test/java/org/apache/iceberg/hive/TestHiveMetastore.java:
##########
@@ -195,6 +195,24 @@ public HiveConf hiveConf() {
return hiveConf;
}
+ /**
+ * Gets the actual connection URL used by the metastore handler.
+ * This is needed because hiveConf() returns the original conf passed to
start(),
+ * which may not have the connection URL that was set in the handler's
serverConf.
+ */
+ public String getConnectionURL() {
Review Comment:
are we using fallback here?
````
// Fallback: construct from DERBY_PATH pattern
return "jdbc:derby:" + DERBY_PATH + ";create=true";
````
someone should be setting the CONNECT_URL_KEY, otherwise, how everything
else works?
is this the place?
````
private static void setupMetastoreDB(String dbURL) throws Exception {
HiveConf conf = new HiveConf();
MetastoreConf.setVar(conf, MetastoreConf.ConfVars.CONNECT_URL_KEY,
"jdbc:derby:" + DERBY_PATH + ";create=true");
TestTxnDbUtil.prepDb(conf);
}
````
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
