thomasrebele opened a new pull request, #6300: URL: https://github.com/apache/hive/pull/6300
[HIVE-29442](https://issues.apache.org/jira/browse/HIVE-29442) ### What changes were proposed in this pull request? The bottom part of [FilterStatsRule#evaluateComparator](https://github.com/apache/hive/blob/7b5433415e42ec92d29636109ea7f522c9354cf4/ql/src/java/org/apache/hadoop/hive/ql/optimizer/stats/annotation/StatsRulesProcFactory.java#L1071-L1267) repeats a very similar code block 6 times. Implementing [HIVE-29364](https://issues.apache.org/jira/browse/HIVE-29364) will likely make the repeated code block even bigger. I suggest to combine those code blocks into a single one, while still keeping the same behavior. ### Why are the changes needed? Preparation of [HIVE-29364](https://issues.apache.org/jira/browse/HIVE-29364) ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? I've disabled the histogram statistics in stats_histogram.q, and regenerated the q.out file. It is the same as without the patch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
