ngsg commented on code in PR #5955:
URL: https://github.com/apache/hive/pull/5955#discussion_r2209349397
##########
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java:
##########
@@ -1728,6 +1728,10 @@ public enum ConfVars {
" and password. Any other value is ignored right now but
may be used later."
+ "If JWT- Supported only in HTTP transport mode. If set, HMS
Client will pick the value of JWT from "
+ "environment variable HMS_JWT and set it in Authorization
header in http request"),
+ METASTORE_CLIENT_CLASS("metastore.client.class",
+ "hive.metastore.client.class",
+ "org.apache.hadoop.hive.metastore.client.ThriftHiveMetaStoreClient",
+ "The name of MetaStoreClient class that implements the
IMetaStoreClient interface."),
Review Comment:
> From my point of view, I would suggest the pattern(the database or table)
or the catalog routed way to choose which the client will use to obtain the
metadata.
I believe this is somewhat similar to the design proposed in HIVE-28879
(Federated Catalog).
From my perspective, I see HIVE-12679 as a milestone for both HIVE-28658
(Iceberg REST Catalog, #5628) and HIVE-28879. So, I'm fine with moving directly
to HIVE-28879 or pursuing any other approach, as long as we aim to support
third-party data catalogs. However, since this ticket predates my contributions
and has many watchers, I want to ask for and respect others' opinions as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
