zabetak commented on code in PR #5919:
URL: https://github.com/apache/hive/pull/5919#discussion_r2207032822
##########
itests/util/src/main/java/org/apache/hadoop/hive/ql/qoption/QTestDatabaseHandler.java:
##########
@@ -82,52 +80,48 @@ AbstractExternalDB create() {
abstract AbstractExternalDB create();
}
- private final Map<DatabaseType, String> databaseToScript = new
EnumMap<>(DatabaseType.class);
+ private final String scriptsDir;
+ private final List<AbstractExternalDB> databases = new ArrayList<>();
Review Comment:
I mean using a `List` and doing a check before/after adding an element. If
we use a `Set` or `Map` we would still need to iterate through all entries if
we want to enforce the two checks mentioned above. The reason that I said that
`List` makes sense is because iteration through all elements is usually faster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
