deniskuzZ commented on code in PR #5952:
URL: https://github.com/apache/hive/pull/5952#discussion_r2198045554
##########
serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinaryTimestamp.java:
##########
@@ -32,6 +37,13 @@ public class LazyBinaryTimestamp extends
LazyBinaryPrimitive<WritableTimestampObjectInspector, TimestampWritableV2>
{
static final Logger LOG = LoggerFactory.getLogger(LazyBinaryTimestamp.class);
+ // Legacy mode flag
+ private static boolean legacyModeEnabled = false;
Review Comment:
Can we pass the flag through the constructor?
````
LazyBinaryTimestamp(WritableTimestampObjectInspector oi, boolean
legacyConversionEnabled) { ..}
````
cachedLazyStruct = new LazyBinaryColumnarStruct(cachedObjectInspector,
notSkipIDs, legacyConversionEnabled);
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
