deniskuzZ commented on code in PR #5923:
URL: https://github.com/apache/hive/pull/5923#discussion_r2184736512
##########
standalone-metastore/packaging/src/assembly/src.xml:
##########
@@ -28,28 +28,38 @@
<format>tar.gz</format>
</formats>
-
<baseDirectory>apache-${project.artifactId}-${project.version}-src</baseDirectory>
+ <baseDirectory>apache-hive-metastore-${project.version}-src</baseDirectory>
<fileSets>
<fileSet>
- <directory>${project.basedir}</directory>
+ <directory>${project.parent.basedir}</directory>
<includes>
<include>DEV-README</include>
Review Comment:
1. `LICENSE` and `NOTICE` do not need a pattern
2. i think it would be good to have `RELEASE_NOTES.txt` for HMS, but i don't
know how to generate it, see
https://issues.apache.org/jira/secure/ConfigureReleaseNote.jspa?projectId=12310843
3. `CHANGELOG` could be dropped from the main assembly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
