kasakrisz commented on code in PR #5559:
URL: https://github.com/apache/hive/pull/5559#discussion_r1873393094
##########
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/monitoring/TezJobMonitor.java:
##########
@@ -280,6 +280,7 @@ public int monitorExecution() {
// best effort
}
console.printError("Execution has failed. stack trace: " +
ExceptionUtils.getStackTrace(e));
+ diagnostics.append(e.getMessage());
Review Comment:
The code you pointed is about copying messages from the `DAGStatus`
instance. However in this special test case this instance is `null` because
the `LockException` is thrown before pulling the status.
https://github.com/apache/hive/blob/cf83d4751271622a9a700c6f2330dbfff38801d2/ql/src/java/org/apache/hadoop/hive/ql/exec/tez/monitoring/TezJobMonitor.java#L171
https://github.com/apache/hive/blob/cf83d4751271622a9a700c6f2330dbfff38801d2/ql/src/java/org/apache/hadoop/hive/ql/exec/tez/monitoring/TezJobMonitor.java#L183
So it seems that heartbeat related checks are handled independently from the
tez jobs status and the response coming from the first one is not fed into
diagnostics.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
