harishjp commented on code in PR #5534:
URL: https://github.com/apache/hive/pull/5534#discussion_r1834613950
##########
llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/OrcEncodedDataReader.java:
##########
@@ -523,14 +528,17 @@ private void cleanupReaders() {
// Ignore.
}
}
- if (rawDataReader != null && isRawDataReaderOpen) {
+ if (rawDataReader != null) {
try {
rawDataReader.close();
rawDataReader = null;
} catch (IOException ex) {
// Ignore.
}
}
+
+ IOUtils.closeQuietly(orcReader);
Review Comment:
The more I think IOUtils.closeQuietly can have issues which get suppresed, I
saw exceptions last time in the cluster where close call failed because of
running out of connections in S3!
```
Ignoring exception when closing input stocks_highpartition_2000(cleanup).
Exception class=org.apache.hadoop.fs.s3a.AWSApiCallTimeoutException
```
It's better to atleast surface these exceptions in the log.
##########
llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/OrcEncodedDataReader.java:
##########
@@ -1109,6 +1122,7 @@ public void open() throws IOException {
long startTime = counters.startTimeCounter();
orcDataReaderRef.open();
counters.recordHdfsTime(startTime);
+ isOpen = true;
Review Comment:
We should set isOpen to false in close method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
