zabetak commented on code in PR #5249: URL: https://github.com/apache/hive/pull/5249#discussion_r1670546447
########## ql/src/test/results/clientpositive/perf/tpcds30tb/tez/cbo_query31.q.out: ########## @@ -1,3 +1,27 @@ +CTE Suggestion 0:HiveProject(ss_addr_sk=[$5], ss_ext_sales_price=[$14], ss_sold_date_sk=[$22]) + HiveFilter(condition=[AND(IS NOT NULL($22), IS NOT NULL($5))]) + HiveTableScan(table=[[default, store_sales]], table:alias=[store_sales]) + +CTE Suggestion 1:HiveProject(ws_bill_addr_sk=[$6], ws_ext_sales_price=[$22], ws_sold_date_sk=[$33]) + HiveFilter(condition=[AND(IS NOT NULL($33), IS NOT NULL($6))]) + HiveTableScan(table=[[default, web_sales]], table:alias=[web_sales]) + +CTE Suggestion 2:HiveProject(ca_address_sk=[$0], ca_county=[$7]) + HiveFilter(condition=[IS NOT NULL($7)]) + HiveTableScan(table=[[default, customer_address]], table:alias=[customer_address]) + +CTE Suggestion 3:HiveProject(d_date_sk=[$0]) + HiveFilter(condition=[AND(=($10, 1), =($6, 2000))]) + HiveTableScan(table=[[default, date_dim]], table:alias=[date_dim]) + +CTE Suggestion 4:HiveProject(d_date_sk=[$0]) + HiveFilter(condition=[AND(=($10, 3), =($6, 2000))]) + HiveTableScan(table=[[default, date_dim]], table:alias=[date_dim]) + +CTE Suggestion 5:HiveProject(d_date_sk=[$0]) + HiveFilter(condition=[AND(=($10, 2), =($6, 2000))]) + HiveTableScan(table=[[default, date_dim]], table:alias=[date_dim]) + Review Comment: Indeed a different suggester could opt to merge these CTEs together by creating a disjunction of the three conditions. At this stage, I wanted to keep `CommonTableExpressionIdentitySuggester` rather simple and leave more elaborate logic for follow-up tickets. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
