kuczoram commented on PR #5192: URL: https://github.com/apache/hive/pull/5192#issuecomment-2111949853
Thanks a lot @ayushtkn for the review! I appreciate your comments very much! I checked the comments from @aturoczy in the old PR. If I don't miss something, he had two suggestions, one about the style of an error message and one about writing unit tests. I fixed the error message and I added unit tests for the whole query generation. Do you think we should write unit tests for the individual methods as well? If you think that it would make sense, I can do that. But maybe I open a different Jira for that, so I won't block this one until it is finished. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
