InvisibleProgrammer commented on code in PR #5186:
URL: https://github.com/apache/hive/pull/5186#discussion_r1558969477
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/jdbc/functions/HeartbeatTxnRangeFunction.java:
##########
@@ -82,7 +82,7 @@ public HeartbeatTxnRangeResponse
execute(MultiDataSourceJdbcResource jdbcResourc
}
if (updateCnt == numTxnsToHeartbeat) {
//fast pass worked, i.e. all txns we were asked to heartbeat were Open
as expected
- context.rollbackToSavepoint(savePoint);
+ context.createSavepoint();
Review Comment:
Based on the original version, I'm pretty sure it shouldn't be a rollback.
But also, I'm not sure if it should be a savepoint as well.
```java
if (updateCnt == numTxnsToHeartbeat) {
//fast pass worked, i.e. all txns we were asked to heartbeat were
Open as expected
dbConn.commit();
return rsp;
}
```
https://github.com/apache/hive/commit/81c89cdb7b01617dc1ab847a52805c16c9a5621a#diff-ccc50cf147261af64a10e20359f9c52f1d4797bc8e03e682d6a88891ee941f02L3606
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
