okumin commented on code in PR #5077:
URL: https://github.com/apache/hive/pull/5077#discussion_r1485585374
##########
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveTableScan.java:
##########
@@ -202,6 +203,12 @@ public HiveTableScan copyIncludingTable(RelDataType
newRowtype) {
// Also include partition list key to trigger cost evaluation even if an
// expression was already generated.
@Override public RelWriter explainTerms(RelWriter pw) {
+ if (pw instanceof RelTreeSignatureWriter) {
+ return super.explainTerms(pw)
+ .item("tableScanTrait", this.tableScanTrait)
+ .itemIf("fromVersion", ((RelOptHiveTable)
table).getHiveTableMD().getVersionIntervalFrom(),
+ isNotBlank(((RelOptHiveTable)
table).getHiveTableMD().getVersionIntervalFrom()));
Review Comment:
HiveTableScan doesn't retain the equivalents of
`TableScanDesc#getPredicateString` or `TableScanDesc#getRowLimit`.
So, we can't unify ASTNodes or RelNodes based on `RelTreeSignature#equals`.
Otherwise, Operators which should not belong to the same group will be unified
later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
