Johannes Schindelin <johannes.schinde...@gmx.de> writes: > ... my Git garden shears [*1*] (essentially, what > git rebase --interactive --preserve-merges *should* have been).
Any plan to fold it into "git rebase -i" as a new (improved) mode of operation, by the way? > However, I could imagine that we actually want this to be more extensible. > After all, all you are doing is to introduce a new rebase -i command that > does nothing else than shelling out to a command. Yup, I tend to agree. Adding "sign" feature (i.e. make it pass -S to "commit [--amend]") may be a good thing, but adding "sign" command to do so is not a great design. There is no inherent reason why "sign" feature implies "--no-edit", and adding a "sign" command like this patch means that the next command somebody else proposes will be "sign-and-reword". We should be able to treat Signing and Rewording as two orthogonal features, one that passes -S, and the other that refrains from passing --no-edit. Otherwise as the number of features grow, the number of commands will see combinatorial growth. Thanks. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
