Vasco Almeida <[email protected]> writes:
> + default:
> + error_msg = xstrfmt(_("bad config line %d in %s"),
> + cf->linenr, cf->name);
> + }
> +
> if (cf->die_on_error)
> - die(_("bad config line %d in %s %s"), cf->linenr,
> cf->origin_type, cf->name);
> + die(error_msg);
As error_msg is a result of xstrfmt() and there is no further
interpolation needed, you would want to say
die("%s", error_msg);
here. It triggers
config.c:541:3: error: format not a string literal and no format arguments
[-Werror=format-security]
Similarly for error() below.
> else
> - return error(_("bad config line %d in %s %s"), cf->linenr,
> cf->origin_type, cf->name);
> + error_return = error(error_msg);
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
