Hi Junio,
On Fri, 22 Jul 2016, Junio C Hamano wrote:
> Johannes Schindelin <johannes.schinde...@gmx.de> writes:
>
> > On Thu, 21 Jul 2016, Johannes Sixt wrote:
> >
> >> The previous commit introduced the first use of ENOTSOCK. This macro is
> >> not available on Windows. Define it as WSAENOTSOCK because that is the
> >> corresponding error value reported by the Windows versions of socket
> >> functions.
> >
> > Thanks for catching this early.
>
> (is that an acked/reviewed-by? it is OK if it is not).
It had been neither, as I had only looked at the patch briefly (which I
deem not enough to account for a review).
However, I now reviewed it properly and offer my Acked-by:.
If it is not too much to ask, I would love to have the following added to
the commit message:
For details, see
https://msdn.microsoft.com/en-us/library/windows/desktop/ms740476.aspx
Thanks,
Dscho
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
