David Aguilar <dav...@gmail.com> writes:
> Call Git::command() and friends directly wherever possible.
> This makes it clear that these operations can be invoked directly
> without needing to manage the current directory and related GIT_*
> environment variables.
Good.
> @@ -88,11 +80,11 @@ sub changed_files
> my @refreshargs = (
> @gitargs, 'update-index',
> '--really-refresh', '-q', '--unmerged');
> - my @diffargs = (@gitargs, 'diff-files', '--name-only', '-z');
> try {
> Git::command_oneline(@refreshargs);
> } catch Git::Error::Command with {};
>
> + my @diffargs = (@gitargs, 'diff-files', '--name-only', '-z');
> my $line = Git::command_oneline(@diffargs);
> my @files;
> if (defined $line) {
This hunk looks like "oops, the @diffargs variable logically belongs
here, not there", correcting an mistake in an earlier step.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
