On Tue, May 17, 2016 at 5:52 PM, Jeff King <[email protected]> wrote: > On Tue, May 17, 2016 at 04:48:33PM -0400, Eric Sunshine wrote: >> On Tue, May 17, 2016 at 4:37 PM, Junio C Hamano <[email protected]> wrote: >> > Eric Sunshine <[email protected]> writes: >> >> + git ${dir:+-C "$dir"} rev-parse --$o >actual && >> > >> > This is kosher POSIX, but I vaguely recall some shells had trouble >> > with the SP between -C and "$dir" in the past. Let's see if anybody >> > screams; hopefully I am misremembering or buggy shells died out. >> >> I also am bothered by a vague recollection of some issue (possibly >> involving the internal space and lack of quotes around the entire >> ${...}), but couldn't remember nor find a reference to the specific >> details. Perhaps someone reading the patch has a better memory than I. > > http://thread.gmane.org/gmane.comp.version-control.git/265094
Thanks for the link. I just tested with FreeBSD 8, and the shell indeed exhibits that broken behavior. The workaround in Kyle's patch isn't the prettiest (and is a bit verbose), but it gets the job done. I can send v3 using that workaround unless Junio wants to patch it locally(?). -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
