Hi Junio, On Fri, 6 May 2016, Junio C Hamano wrote:
> * jc/fsck-nul-in-commit (2016-04-14) 2 commits > - fsck: detect and warn a commit with embedded NUL > - fsck_commit_buffer(): do not special case the last validation > > "git fsck" learned to catch NUL byte in a commit object as > potential error and warn. > > What was the status of this one? Ready to proceed? I think this code looks fine. Maybe two comments on the test: > test_must_fail git -c fsck.nulInCommit=error fsck 2>warn.1 && > git fsck 2>warn.2 && > grep nulInCommit warn.2 1) warn.1 is not used. Maybe skip that redirection? 2) I was under the impression that we preferred test_i18ngrep over grep... Thanks, Dscho -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
