On Thu, Apr 28, 2016 at 6:37 AM, Jeff King <p...@peff.net> wrote: > Commit 14111fc (git: submodule honor -c credential.* from > command line, 2016-02-29) taught git-submodule.sh to save > the sanitized value of $GIT_CONFIG_PARAMETERS when clearing > the environment for a submodule. However, it failed to > export the result, meaning that it had no effect for any > sub-programs. > > We didn't catch this in our initial tests because we checked > only the "clone" case, which does not go through the shell > script at all. Provoking "git submodule update" to do a > fetch demonstrates the bug. > > Noticed-by: Lars Schneider <larsxschnei...@gmail.com> > Signed-off-by: Jeff King <p...@peff.net> > --- > git-submodule.sh | 1 + > t/t5550-http-fetch-dumb.sh | 17 +++++++++++++++++ > 2 files changed, 18 insertions(+) > > diff --git a/git-submodule.sh b/git-submodule.sh > index 2a84d7e..3a40d4b 100755 > --- a/git-submodule.sh > +++ b/git-submodule.sh > @@ -200,6 +200,7 @@ sanitize_submodule_env() > sanitized_config=$(git submodule--helper sanitize-config) > clear_local_git_env > GIT_CONFIG_PARAMETERS=$sanitized_config > + export GIT_CONFIG_PARAMETERS
why not export GIT_CONFIG_PARAMETERS=$santized_config ? Thanks, Jake -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
