On Wed, Apr 27, 2016 at 8:04 AM, Junio C Hamano <gits...@pobox.com> wrote: > Ye Xiaolong <xiaolong...@intel.com> writes: > >> On Tue, Apr 26, 2016 at 11:58:39AM -0700, Junio C Hamano wrote: >> >>>Let's hear from folks at Intel ;-) Both of the above sounds like >>>sensible enhancements to me. >> >> Shall I squash these enhancements in this series, or I need to make >> another patch for them? > > The update being discussed is not a "oops, the series without this > update is embarrassingly flawed" fix, but rather "the series is good > enough to be used as-is, but here is to potentially make it even > better", I'd prefer to have it as a separate, follow-up patch that > applies on top of what has been queued. That way, if this turns out > to be not so good idea, removing it alone while preserving what is > already there will be easier, and also others who will be studying > the code to further enhance the heuristics of base selection in the > future will benefit.
I agree. I was just suggesting going the extra mile to make it easier for the user. :) -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
