On Fri, Apr 22, 2016 at 05:38:23PM +0200, SZEDER Gábor wrote: > To get the 'value' from '--option=value', test-lib.sh parses said > option running 'expr' with a regexp. This involves a subshell, an > external process, and a lot of non-alphanumeric characters in the > regexp. > > Use a much simpler shell parameter expansion instead to do the same.
Looks OK to me. I doubt the extra process is a killer (we only parse options once per script), but the result is definitely more readable, IMHO. For some reason I had always assumed that complicated pattern matching with "#" was non-POSIX, but I checked and it is definitely in there. > --- > t/test-lib.sh | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) I count 5 cases in my copy of test-lib.sh. I think you are missing "--run". -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
