On Wed, Apr 13, 2016 at 4:39 AM, Pranit Bauva <pranit.ba...@gmail.com> wrote: > On Wed, Apr 13, 2016 at 11:26 AM, Eric Sunshine <sunsh...@sunshineco.com> > wrote: >> On Tue, Apr 12, 2016 at 7:02 PM, Pranit Bauva <pranit.ba...@gmail.com> wrote: >>> +test_expect_success 'OPT_COUNTUP() resets to 0 with --no- flag' ' >>> + test-parse-options --no-verbose >output 2>output.err && >>> + test_must_be_empty output.err && >>> + test_cmp expect output >>> +' >> >> In my v12 review, I noticed that neither --no-verbose nor --no-quiet >> was being tested by t0040 (which is conceptually independent of the >> OPT__COUNTUP change) and suggested[3] that you add a new patch to >> address that shortcoming. This idea was followed up by [1] saying that >> this test (here) could then be dropped since the case it checks would >> already be covered by the new patch. My impression was that you >> agreed[4] that that made sense, however, this test is still here. Did >> I misunderstand your response[4]? >> >> [1]: http://article.gmane.org/gmane.comp.version-control.git/290662 >> [2]: http://article.gmane.org/gmane.comp.version-control.git/289991 >> [3]: http://article.gmane.org/gmane.comp.version-control.git/290655 >> [4]: http://article.gmane.org/gmane.comp.version-control.git/290787 > > I actually did include the tests in the patch 3/6[1]. I mentioned in > my response[2] that I will include the tests between 2/5 and 3/5. > Since, after that no email was exchanged, I thought you agreed.
I'm not sure that I understand what you are saying since the --no-verbose test does not seem to be included in the patch you cite (it is instead in the present patch under discussion). Perhaps there is some miscommunication and misunderstanding. > [1]: http://article.gmane.org/gmane.comp.version-control.git/291310 > [2]:http://article.gmane.org/gmane.comp.version-control.git/290787 -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
