Michael Rappazzo <rappa...@gmail.com> writes: > t1500-rev-parse has many tests which change directories and leak > environment variables. This makes it difficult to add new tests without > minding the environment variables and current directory. > > Each test is now setup, executed, and cleaned up without leaving anything > behind. Tests which have textual expectations have been converted to use > test_cmp (which will show a diff when the test is run with --verbose). > > Signed-off-by: Michael Rappazzo <rappa...@gmail.com> > ---
Applying this patch on top of sg/completion-updates topic makes the tests much more readable. Given that sg/completion-updates topic is planned to be rerolled ($gmane/287839), I think it would be better to do this as a preparatory clean-up patch before it makes the tests uglier by doing "add --absolute-git-dir" patch in the middle. Gábor, what do you think? -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
